intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-22 23:49:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

[NFC][mlir][AsmPrinter] Don't compute resourceStr when --mlir-elide-resource-strings-if-larger=0 (#138275)

Browse Source 
When skipping the printing of large DenseResourceElementsAttr with
--mlir-elide-resource-strings-if-larger,
we need to compute resourceStr to check if the string is small enough to
print.

With --mlir-elide-resource-strings-if-larger set to 0, nothing should be
printed, but we still compute the size.

This change will allow an early return when
--mlir-elide-resource-strings-if-larger=0, making the print process
faster.
This commit is contained in:
Xiang Li
2025-05-02 10:41:14 -04:00
committed by GitHub
parent 580da48a93
commit c54122fe53
2 changed files with 14 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
mlir/lib/IR/AsmPrinter.cpp
View File

@@ -3463,6 +3463,10 @@ void OperationPrinter::printResourceFileMetadata(
std::optional<uint64_t> charLimit =
printerFlags.getLargeResourceStringLimit();
if (charLimit.has_value()) {
// Don't compute resourceStr when charLimit is 0.
if (charLimit.value() == 0)
return;
llvm::raw_string_ostream ss(resourceStr);
valueFn(ss);

10
mlir/test/IR/pretty-resources-print.mlir
View File

@@ -2,11 +2,16 @@
// RUN: mlir-opt %s --mlir-elide-resource-strings-if-larger=20| FileCheck %s
// RUN: mlir-opt %s --mlir-elide-resource-strings-if-larger=0| FileCheck %s --check-prefix=ZERO
// To ensure we print the resource keys, have reference to them
// CHECK: attr = dense_resource<blob1> : tensor<3xi64>
// ZERO: attr = dense_resource<blob1> : tensor<3xi64>
"test.blob1op"() {attr = dense_resource<blob1> : tensor<3xi64> } : () -> ()
// CHECK-NEXT: attr = dense_resource<blob2> : tensor<3xi64>
// ZERO-NEXT: attr = dense_resource<blob2> : tensor<3xi64>
"test.blob2op"() {attr = dense_resource<blob2> : tensor<3xi64> } : () -> ()
// CHECK: {-#
@@ -21,6 +26,11 @@
// CHECK-NEXT: }
// CHECK-NEXT: #-}
// Make sure no external_resources are printed when --mlir-elide-resource-strings-if-larger=0
// ZERO: {-#
// ZERO-EMPTY:
// ZERO-NEXT: #-}
{-#
dialect_resources: {
builtin: {