intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-21 03:50:33 +08:00
Code Issues Packages Projects Releases Wiki Activity

[utils] Use stricter SSA regexp for CHECK-SAME. (#128083)

Browse Source 
When CHECK-SAME checks are split across multiple lines,
the '.*' regexp for the SSA variable name may cause problems, e.g.:
```
// CHECK_LABEL: func.func @whatever(
// CHECK-SAME: %[[VAL_0:.*]]: i32,
// CHECK-SAME: %[[VAL_1:.*]]: i32,
// CHECK-SAME: %[[VAL_2:.*]]: i64)
```

This will not work for `func.func @whatever(%0: i32, %1: i32, %2: i64)`,
because VAL_0 will match to `0: i32, %1`.
This commit is contained in:
Slava Zakharin
2025-02-20 21:18:12 -08:00
committed by GitHub
parent cc46d00a86
commit cc675c635b
1 changed files with 12 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
mlir/utils/generate-test-checks.py
View File

@@ -159,7 +159,7 @@ def get_num_ssa_results(input_line):
# Process a line of input that has been split at each SSA identifier '%'.
def process_line(line_chunks, variable_namer):
def process_line(line_chunks, variable_namer, strict_name_re=False):
output_line = ""
# Process the rest that contained an SSA value name.
@@ -180,7 +180,14 @@ def process_line(line_chunks, variable_namer):
else:
# Otherwise, generate a new variable.
variable = variable_namer.generate_name(ssa_name)
output_line += "%[[" + variable + ":.*]]"
if strict_name_re:
# Use stricter regexp for the variable name, if requested.
# Greedy matching may cause issues with the generic '.*'
# regexp when the checks are split across several
# lines (e.g. for CHECK-SAME).
output_line += "%[[" + variable + ":" + SSA_RE_STR + "]]"
else:
output_line += "%[[" + variable + ":.*]]"
# Append the non named group.
output_line += chunk[len(ssa_name) :]
@@ -390,7 +397,9 @@ def main():
output_line += " " * len(ssa_split[0])
# Process the rest of the line.
output_line += process_line([argument], variable_namer)
output_line += process_line(
[argument], variable_namer, strict_name_re=True
)
# Append the output line.
output_segments[-1].append(output_line)