intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-17 06:40:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb] Fix a test if hardware breakpoints are not supported (#168813)

Browse Source 
If `HardwareBreakpointTestBase.supports_hw_breakpoints()` returns False,
`SimpleHWBreakpointTest.does_not_support_hw_breakpoints()` returns None,
so the test runs and fails. However, it should be skipped instead.

The test was added in #146602, while `supports_hw_breakpoints()` was
changed in #146609, which was landed earlier despite having a bigger
number.
This commit is contained in:
Igor Kudrin
2025-11-20 09:45:54 -08:00
committed by GitHub
parent 66ddc9b3e7
commit ccdb71932a
1 changed files with 10 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
lldb/test/API/functionalities/breakpoint/hardware_breakpoints/simple_hw_breakpoints/TestSimpleHWBreakpoints.py
View File

@@ -7,13 +7,7 @@ from functionalities.breakpoint.hardware_breakpoints.base import *
class SimpleHWBreakpointTest(HardwareBreakpointTestBase):
def does_not_support_hw_breakpoints(self):
# FIXME: Use HardwareBreakpointTestBase.supports_hw_breakpoints
if super().supports_hw_breakpoints() is None:
return "Hardware breakpoints are unsupported"
return None
@skipTestIfFn(does_not_support_hw_breakpoints)
@skipTestIfFn(HardwareBreakpointTestBase.hw_breakpoints_unsupported)
def test(self):
"""Test SBBreakpoint::SetIsHardware"""
self.build()
@@ -35,16 +29,13 @@ class SimpleHWBreakpointTest(HardwareBreakpointTestBase):
# breakpoint will be marked as a hardware breakpoint.
self.assertTrue(break_on_me_bp.IsHardware())
if super().supports_hw_breakpoints():
self.assertSuccess(error)
self.assertSuccess(error)
# Continue to our Hardware breakpoint and verify that's the reason
# we're stopped.
process.Continue()
self.expect(
"thread list",
STOPPED_DUE_TO_BREAKPOINT,
substrs=["stopped", "stop reason = breakpoint"],
)
else:
self.assertFailure(error)
# Continue to our Hardware breakpoint and verify that's the reason
# we're stopped.
process.Continue()
self.expect(
"thread list",
STOPPED_DUE_TO_BREAKPOINT,
substrs=["stopped", "stop reason = breakpoint"],
)