intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-13 02:38:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ORC] Avoid self-dependence in SuperNode dependence graph. (#169286)

Browse Source 
Avoid adding any given SuperNode SN to its own SuperNode-deps set. This
saves us from trying to redundantly merge its dependencies back into
itself (a no-op, but a potentially expensive one).
This commit is contained in:
Lang Hames
2025-11-24 22:50:29 +11:00
committed by GitHub
parent 5d2fc9408e
commit d162c91c01
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
llvm/include/llvm/ExecutionEngine/Orc/WaitingOnGraph.h
View File

@@ -500,7 +500,7 @@ private:
if (I == SN->Deps.end())
continue;
for (auto &[DefElem, DefSN] : DefElems)
if (I->second.erase(DefElem))
if (I->second.erase(DefElem) && DefSN != SN.get())
SNDeps.insert(DefSN);
if (I->second.empty())
SN->Deps.erase(I);
@@ -511,11 +511,13 @@ private:
// Compute transitive closure of deps for each node.
static void propagateSuperNodeDeps(SuperNodeDepsMap &SuperNodeDeps) {
for (auto &[SN, Deps] : SuperNodeDeps) {
DenseSet<SuperNode *> Reachable({SN});
DenseSet<SuperNode *> Reachable;
SmallVector<SuperNode *> Worklist(Deps.begin(), Deps.end());
while (!Worklist.empty()) {
auto *DepSN = Worklist.pop_back_val();
if (DepSN == SN)
continue;
if (!Reachable.insert(DepSN).second)
continue;
auto I = SuperNodeDeps.find(DepSN);
@@ -537,9 +539,11 @@ private:
if (I == SuperNodeDeps.end())
continue;
for (auto *DepSN : I->second)
for (auto *DepSN : I->second) {
assert(DepSN != SN.get() && "Unexpected self-dependence for SN");
for (auto &[Container, Elems] : DepSN->Deps)
SN->Deps[Container].insert(Elems.begin(), Elems.end());
}
}
}