intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-26 12:26:52 +08:00
Code Issues Packages Projects Releases Wiki Activity

Report an error if an inferred alignment for a shared symbol is too large.

Browse Source 
Differential Revision: https://reviews.llvm.org/D39697

llvm-svn: 317528
This commit is contained in:
Rui Ueyama
2017-11-07 00:12:05 +00:00
parent 1a46affb45
commit d5e2e8393b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lld/ELF/InputFiles.cpp
View File

@@ -809,13 +809,15 @@ template <class ELFT> void SharedFile<ELFT>::parseRest() {
// files because the loader takes care of it. However, if we promote a
// DSO symbol to point to .bss due to copy relocation, we need to keep
// the original alignment requirements. We infer it here.
uint32_t Alignment = 1;
uint64_t Alignment = 1;
if (Sym.st_value)
Alignment = 1ULL << countTrailingZeros((uint64_t)Sym.st_value);
if (0 < Sym.st_shndx && Sym.st_shndx < Sections.size()) {
uint32_t SecAlign = Sections[Sym.st_shndx].sh_addralign;
uint64_t SecAlign = Sections[Sym.st_shndx].sh_addralign;
Alignment = std::min(Alignment, SecAlign);
}
if (Alignment > UINT32_MAX)
error(toString(this) + ": alignment too large: " + Name);
if (!Hidden)
Symtab->addShared(Name, this, Sym, Alignment, Ver);