intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-17 06:40:01 +08:00
Code Issues Packages Projects Releases Wiki Activity

Revert "[analyzer] Create a temporary region for rvalue structs when accessing fields"

Browse Source 
This reverts commit 6f61df3e7256413dcb99afb9673f4206e3c4992c.

llvm-svn: 164877
This commit is contained in:
Jordan Rose
2012-09-29 01:36:51 +00:00
parent d9b0268401
commit d60b9168fa
3 changed files with 13 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
clang/lib/StaticAnalyzer/Core/ExprEngine.cpp
View File

@@ -1505,17 +1505,17 @@ void ExprEngine::VisitMemberExpr(const MemberExpr *M, ExplodedNode *Pred,
ProgramStateRef state = Pred->getState();
const LocationContext *LCtx = Pred->getLocationContext();
SVal baseExprVal = state->getSVal(baseExpr, Pred->getLocationContext());
// If we're accessing a field of an rvalue, we need to treat it like a
// temporary object.
if (isa<NonLoc>(baseExprVal)) {
const MemRegion *R =
svalBuilder.getRegionManager().getCXXTempObjectRegion(baseExpr, LCtx);
SVal L = loc::MemRegionVal(R);
state = state->bindLoc(L, baseExprVal);
baseExprVal = L;
if (isa<nonloc::LazyCompoundVal>(baseExprVal) ||
isa<nonloc::CompoundVal>(baseExprVal) ||
// FIXME: This can originate by conjuring a symbol for an unknown
// temporary struct object, see test/Analysis/fields.c:
// (p = getit()).x
isa<nonloc::SymbolVal>(baseExprVal)) {
Bldr.generateNode(M, Pred, state->BindExpr(M, LCtx, UnknownVal()));
return;
}
// For all other cases, compute an lvalue.
SVal L = state->getLValue(field, baseExprVal);
if (M->isGLValue()) {
ExplodedNodeSet Tmp;

11
clang/test/Analysis/fields.c
View File

@@ -1,6 +1,4 @@
// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core,debug.ExprInspection %s -analyzer-store=region -verify
void clang_analyzer_eval(int);
// RUN: %clang_cc1 -analyze -analyzer-checker=core,alpha.core %s -analyzer-store=region -verify
unsigned foo();
typedef struct bf { unsigned x:2; } bf;
@@ -35,10 +33,3 @@ void testNullAddress() {
int *px = &p->x; // expected-warning{{Access to field 'x' results in a dereference of a null pointer (loaded from variable 'p')}}
*px = 1; // No warning because analysis stops at the previous line.
}
void testLazyCompoundVal() {
Point p = {42, 0};
Point q;
clang_analyzer_eval((q = p).x == 42); // expected-warning{{TRUE}}
clang_analyzer_eval(q.x == 42); // expected-warning{{TRUE}}
}

4
clang/test/Analysis/reference.cpp
View File

@@ -116,8 +116,10 @@ void testReferenceAddress(int &x) {
struct S { int &x; };
// FIXME: Should be TRUE. Fields of return-by-value structs are not yet
// symbolicated. Tracked by <rdar://problem/12137950>.
extern S getS();
clang_analyzer_eval(&getS().x != 0); // expected-warning{{TRUE}}
clang_analyzer_eval(&getS().x != 0); // expected-warning{{UNKNOWN}}
extern S *getSP();
clang_analyzer_eval(&getSP()->x != 0); // expected-warning{{TRUE}}