intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-25 10:55:58 +08:00
Code Issues Packages Projects Releases Wiki Activity

[Bazel] Make td_library usable as data

Browse Source 
This patch makes it possible to list a td_library as a rule's data
attribute and get its source files and all its transitive dependencies
at runtime. This is useful for, e.g. shell tests running tblgen.

Note that this is a bit different from how a "normal" (e.g. C++) library
rule would work because those have actual library outputs and the
td_library rule just bundles some source files and includes. If someone
wanted to make use of the includes, they would have to access the TdInfo
provider, but this keeps simple things simple.

Reviewed By: jpienaar

Differential Revision: https://reviews.llvm.org/D106922
This commit is contained in:
Geoffrey Martin-Noble
2021-07-27 17:01:19 -07:00
parent f3a8a7b91e
commit d983499543
1 changed files with 28 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
utils/bazel/llvm-project-overlay/mlir/tblgen.bzl
View File

@@ -100,8 +100,21 @@ def _td_library_impl(ctx):
_resolve_includes(ctx, ctx.attr.includes),
ctx.attr.deps,
)
# Note that we include srcs in runfiles. A td_library doesn't compile to
# produce an output: it's just a depset of source files and include
# directories. So if it is needed for execution of some rule (likely
# something running tblgen as a test action), the files needed are the same
# as the source files.
# Note: not using merge_all, as that is not available in Bazel 4.0
runfiles = ctx.runfiles(ctx.files.srcs)
for src in ctx.attr.srcs:
runfiles = runfiles.merge(src[DefaultInfo].default_runfiles)
for dep in ctx.attr.deps:
runfiles = runfiles.merge(dep[DefaultInfo].default_runfiles)
return [
DefaultInfo(files = trans_srcs),
DefaultInfo(files = trans_srcs, runfiles = runfiles),
TdInfo(
transitive_sources = trans_srcs,
transitive_includes = trans_includes,
@@ -224,11 +237,6 @@ gentbl_rule = rule(
def _gentbl_test_impl(ctx):
td_file = ctx.file.td_file
trans_srcs = _get_transitive_srcs(
ctx.files.td_srcs + [td_file],
ctx.attr.deps,
)
# Note that we have two types of includes here. The deprecated ones expanded
# only by "_prefix_roots" are already relative to the execution root, i.e.
# may contain an `external/<workspace_name>` prefix if the current workspace
@@ -256,18 +264,26 @@ def _gentbl_test_impl(ctx):
is_executable = True,
)
# Note: not using merge_all, as that is not available in Bazel 4.0
runfiles = ctx.runfiles(
files = [ctx.executable.tblgen],
transitive_files = _get_transitive_srcs(
ctx.files.td_srcs + [td_file],
ctx.attr.deps,
),
)
for src in ctx.attr.td_srcs:
runfiles = runfiles.merge(src[DefaultInfo].default_runfiles)
for dep in ctx.attr.deps:
runfiles = runfiles.merge(dep[DefaultInfo].default_runfiles)
return [
coverage_common.instrumented_files_info(
ctx,
source_attributes = ["td_file", "td_srcs"],
dependency_attributes = ["tblgen", "deps"],
),
DefaultInfo(
runfiles = ctx.runfiles(
[ctx.executable.tblgen],
transitive_files = trans_srcs,
),
),
DefaultInfo(runfiles = runfiles),
]
gentbl_test = rule(