mirror of
https://github.com/intel/llvm.git
synced 2026-01-20 01:58:44 +08:00
[lldb/crashlog] Fix JSON ObjectFile module loading issue
In 27f27d15f6, we added a new way to use textual (JSON) object files
and symbol files with the interactive crashlog command, using the
inlined symbols from the crash report.
However, there was a missing piece after successfully adding the textual
module to the target, we didn't mark it as available causing the module
loading to exit early.
This patch addresses that issue by marking the module as available when
added successfully to the target.
Differential Revision: https://reviews.llvm.org/D149477
Signed-off-by: Med Ismail Bennani <ismail@bennani.ma>
This commit is contained in:
@@ -401,6 +401,11 @@ class Image:
|
||||
with open(tf.name, 'w') as f:
|
||||
f.write(json.dumps(data, indent=4))
|
||||
self.module = target.AddModule(tf.name, None, uuid_str)
|
||||
if self.module:
|
||||
# If we were able to add the module with inlined
|
||||
# symbols, we should mark it as available so load_module
|
||||
# does not exit early.
|
||||
self.unavailable = False
|
||||
if not self.module and not self.unavailable:
|
||||
return 'error: unable to get module for (%s) "%s"' % (
|
||||
self.arch, self.get_resolved_path())
|
||||
|
||||
Reference in New Issue
Block a user