intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-16 21:55:39 +08:00
Code Issues Packages Projects Releases Wiki Activity

[ObjC][ProvenanceEval] Only evaluate pointers (#136876)

Browse Source 
I believe this pass should only be calling PA.related() on pointer
arguments -- the operation is not really meaningful for non-pointers.

I've adjusted the test to use ptr loads instead of i8 loads, which I
believe aligns with how these special globals would actually be used,
and which is probably what this was intending to test.

Ran into this while trying to eliminate illegal non-pointer AA queries.
This commit is contained in:
Nikita Popov
2025-05-02 11:01:38 +02:00
committed by GitHub
parent aa10f879dc
commit df264170f7
2 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
llvm/lib/Transforms/ObjCARC/ProvenanceAnalysisEvaluator.cpp
View File

@@ -27,6 +27,8 @@ static StringRef getName(Value *V) {
static void insertIfNamed(SetVector<Value *> &Values, Value *V) {
if (!V->hasName())
return;
if (!V->getType()->isPointerTy())
return;
Values.insert(V);
}

30
llvm/test/Transforms/ObjCARC/provenance.ll
View File

@@ -7,32 +7,32 @@
@g4 = global i8 0, section "__TEXT,__objc_methname,cstring_literals"
@g5 = global i8 0, section "__TEXT,__cstring,cstring_literals"
declare void @g(i8)
declare void @g(ptr)
define void @f(ptr %a, ptr %b, ptr %c) {
%y1 = load i8, ptr %a
call void @g(i8 %y1)
%y1 = load ptr, ptr %a
call void @g(ptr %y1)
%y2 = load ptr, ptr %b
%y3 = load ptr, ptr %c
%x0 = load i8, ptr @"\01l_objc_msgSend_fixup_"
call void @g(i8 %x0)
%x0 = load ptr, ptr @"\01l_objc_msgSend_fixup_"
call void @g(ptr %x0)
%x1 = load i8, ptr @g1
call void @g(i8 %x1)
%x1 = load ptr, ptr @g1
call void @g(ptr %x1)
%x2 = load i8, ptr @g2
call void @g(i8 %x2)
%x2 = load ptr, ptr @g2
call void @g(ptr %x2)
%x3 = load i8, ptr @g3
call void @g(i8 %x3)
%x3 = load ptr, ptr @g3
call void @g(ptr %x3)
%x4 = load i8, ptr @g4
call void @g(i8 %x4)
%x4 = load ptr, ptr @g4
call void @g(ptr %x4)
%x5 = load i8, ptr @g5
call void @g(i8 %x5)
%x5 = load ptr, ptr @g5
call void @g(ptr %x5)
ret void
}