intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-29 21:26:59 +08:00
Code Issues Packages Projects Releases Wiki Activity

[mlir][bufferization] Fix bug in findValueInReverseUseDefChain

Browse Source 
`alwaysIncludeLeaves` was not respected by all code paths.

Differential Revision: https://reviews.llvm.org/D144187
This commit is contained in:
Matthias Springer
2023-02-16 16:05:58 +01:00
parent 4565bc00de
commit e44f405bb4
2 changed files with 19 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
mlir/lib/Dialect/Bufferization/IR/BufferizableOpInterface.cpp
View File

@@ -505,7 +505,8 @@ llvm::SetVector<Value> AnalysisState::findValueInReverseUseDefChain(
if (followEquivalentOnly && a.relation != BufferRelation::Equivalent) {
// Stop iterating if `followEquivalentOnly` is set but the alias is not
// equivalent.
result.insert(value);
if (alwaysIncludeLeaves)
result.insert(value);
} else {
workingSet.insert(a.opOperand->get());
}

17
mlir/test/Dialect/Bufferization/Transforms/one-shot-bufferize-empty-tensor-elimination.mlir
View File

@@ -204,3 +204,20 @@ func.func @eleminate_multiple_ops(%t: tensor<?xf32> {bufferization.buffer_layout
%r1 = tensor.insert_slice %if into %t[42][%sz][1]: tensor<?xf32> into tensor<?xf32>
return %r1: tensor<?xf32>
}
// -----
// This is a regression test. Make sure that the tensor.extract_slice is not
// eliminated.
// CHECK-LABEL: func.func @regression_do_not_eliminate_non_empty(
// CHECK: memref.subview
// CHECK: memref.subview
// CHECK: memref.copy
func.func @regression_do_not_eliminate_non_empty(
%t: tensor<10xf32>, %t2: tensor<10xf32>) -> tensor<10xf32> {
%1 = tensor.extract_slice %t[0] [5] [1] : tensor<10xf32> to tensor<5xf32>
%2 = tensor.insert_slice %1 into %t2[1] [5] [1]
: tensor<5xf32> into tensor<10xf32>
return %2 : tensor<10xf32>
}