mirror of
https://github.com/intel/llvm.git
synced 2026-01-13 19:08:21 +08:00
[libc] Use a sensible default when TEST_UNDECLARED_OUTPUTS_DIR is unset. (#167422)
There is no guarantee that this environment variable is set. Eg, when running a test outside of the build system, such as under a debugger. And passing a nullptr to the string constructor is undefined. Use an empty string, which seems like it is close to the original intent.
This commit is contained in:
committed by
GitHub
parent
9fce00469d
commit
e77001c9f5
@@ -20,6 +20,10 @@ namespace testing {
|
||||
CString libc_make_test_file_path_func(const char *file_name) {
|
||||
// This is the path to the folder bazel wants the test outputs written to.
|
||||
const char *UNDECLARED_OUTPUTS_PATH = getenv("TEST_UNDECLARED_OUTPUTS_DIR");
|
||||
// Do something sensible if not run under bazel, otherwise this may segfault
|
||||
// when constructing the string.
|
||||
if (UNDECLARED_OUTPUTS_PATH == nullptr)
|
||||
UNDECLARED_OUTPUTS_PATH = "";
|
||||
|
||||
return cpp::string(UNDECLARED_OUTPUTS_PATH) + file_name;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user