[flang][openacc] Resolve symbol in device, host and self clause

Some symbols were not resolved in the device, host and self clause
resulting in an `Internal: no symbol found` error.

This patch adds symbol resolution for these clauses.

Reviewed By: razvanlupusoru

Differential Revision: https://reviews.llvm.org/D153919
This commit is contained in:
Valentin Clement
2023-06-28 09:08:22 -07:00
parent 9ed76f3958
commit eeba037e0b
5 changed files with 44 additions and 2 deletions

View File

@@ -595,6 +595,8 @@ public:
AccPrivate, AccFirstPrivate, AccShared,
// OpenACC data-mapping attribute
AccCopyIn, AccCopyOut, AccCreate, AccDelete, AccPresent,
// OpenACC data-movement attribute
AccDevice, AccHost, AccSelf,
// OpenACC miscellaneous flags
AccCommonBlock, AccThreadPrivate, AccReduction, AccNone, AccPreDetermined,
// OpenMP data-sharing attribute

View File

@@ -192,6 +192,27 @@ public:
return false;
}
bool Pre(const parser::AccClause::Device &x) {
ResolveAccObjectList(x.v, Symbol::Flag::AccDevice);
return false;
}
bool Pre(const parser::AccClause::Host &x) {
ResolveAccObjectList(x.v, Symbol::Flag::AccHost);
return false;
}
bool Pre(const parser::AccClause::Self &x) {
const std::optional<parser::AccSelfClause> &accSelfClause = x.v;
if (accSelfClause &&
std::holds_alternative<parser::AccObjectList>((*accSelfClause).u)) {
const auto &accObjectList =
std::get<parser::AccObjectList>((*accSelfClause).u);
ResolveAccObjectList(accObjectList, Symbol::Flag::AccSelf);
}
return false;
}
void Post(const parser::Name &);
private:
@@ -210,6 +231,9 @@ private:
Symbol::Flag::AccPrivate, Symbol::Flag::AccFirstPrivate,
Symbol::Flag::AccReduction};
static constexpr Symbol::Flags accDataMvtFlags{
Symbol::Flag::AccDevice, Symbol::Flag::AccHost, Symbol::Flag::AccSelf};
static constexpr Symbol::Flags accFlagsRequireMark{};
void PrivatizeAssociatedLoopIndex(const parser::OpenACCLoopConstruct &);

View File

@@ -45,7 +45,7 @@ program openacc_parallel_loop_validity
end do
!ERROR: SELF clause on the PARALLEL LOOP directive only accepts optional scalar logical expression
!$acc parallel loop self(bb, cc(:))
!$acc parallel loop self(bb, cc(:,:))
do i = 1, N
a(i) = 3.14
end do

View File

@@ -0,0 +1,16 @@
! RUN: %flang_fc1 -fopenacc %s
! Check that symbol are correctly resolved in device, host and self clause.
program test_resolve04
real :: a(10), b(10)
common /foo/ b, c
!$acc data create(/foo/)
!$acc update device(/foo/)
!$acc update host(/foo/)
!$acc update self(/foo/)
!$acc end data
end

View File

@@ -38,7 +38,7 @@ program openacc_update_validity
!ERROR: At most one ASYNC clause can appear on the UPDATE directive
!$acc update host(aa, bb) async(1) async(2)
!$acc update self(bb, cc(:)) wait(1)
!$acc update self(bb, cc(:,:)) wait(1)
!ERROR: SELF clause on the UPDATE directive must have a var-list
!$acc update self