intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-23 07:58:23 +08:00
Code Issues Packages Projects Releases Wiki Activity

keymethod -> keyfunction

Browse Source 
Pointed out by ruiu in rLLD349969

llvm-svn: 349974
This commit is contained in:
Fangrui Song
2018-12-21 22:57:11 +00:00
parent b53eeb6f4c
commit f747971bf1
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lld/ELF/Relocations.cpp
View File

@@ -665,7 +665,7 @@ static bool maybeReportUndefined(Symbol &Sym, InputSectionBase &Sec,
if (Sym.getName().startswith("_ZTV"))
Msg += "\nthe vtable symbol may be undefined because the class is missing "
"its key function (see https://lld.llvm.org/missingkeymethod)";
"its key function (see https://lld.llvm.org/missingkeyfunction)";
if ((Config->UnresolvedSymbols == UnresolvedPolicy::Warn && CanBeExternal) ||
Config->NoinhibitExec) {

2
lld/docs/missingkeymethod.rst → lld/docs/missingkeyfunction.rst
View File

@@ -4,7 +4,7 @@ Missing Key Method
If your build failed with a linker error something like this::
foo.cc:28: error: undefined reference to 'vtable for C'
the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeymethod)
the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
it's likely that your class C has a key function (defined by the ABI as the first
non-pure, non-inline, virtual method), but you haven't actually defined it.

2
lld/test/ELF/undef.s
View File

@@ -21,7 +21,7 @@
# CHECK: >>> {{.*}}:(.text+0x10)
# CHECK: error: undefined symbol: vtable for Foo
# CHECK: the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeymethod)
# CHECK: the vtable symbol may be undefined because the class is missing its key function (see https://lld.llvm.org/missingkeyfunction)
# CHECK: error: undefined symbol: zed2
# CHECK: >>> referenced by {{.*}}.o:(.text+0x0) in archive {{.*}}2.a