[builtins] Fix undefined behavior in negdi2.c and negti2.c

When compiling the builtins with the undefined behavior sanitizer and running testcases you end up with the following warning:

UBSan: negdi2.c:20:10: negation of -9223372036854775808 cannot be represented in type 'di_int' (aka 'long long'); cast to an unsigned type to negate this value to itself

This can be avoided by doing negation in a matching unsigned variant of the type.

The same kind of pattern is found in negti2.c

This was found in an out of tree target.

Reviewed By: MaskRay

Differential Revision: https://reviews.llvm.org/D158818
This commit is contained in:
Karl-Johan Karlsson
2023-08-28 06:14:45 +02:00
parent 56255e0421
commit fb463778a7
2 changed files with 2 additions and 2 deletions

View File

@@ -17,5 +17,5 @@
COMPILER_RT_ABI di_int __negdi2(di_int a) {
// Note: this routine is here for API compatibility; any sane compiler
// should expand it inline.
return -a;
return -(du_int)a;
}

View File

@@ -19,7 +19,7 @@
COMPILER_RT_ABI ti_int __negti2(ti_int a) {
// Note: this routine is here for API compatibility; any sane compiler
// should expand it inline.
return -a;
return -(tu_int)a;
}
#endif // CRT_HAS_128BIT