mirror of
https://github.com/intel/llvm.git
synced 2026-01-21 12:19:23 +08:00
[builtins] Fix undefined behavior in negdi2.c and negti2.c
When compiling the builtins with the undefined behavior sanitizer and running testcases you end up with the following warning: UBSan: negdi2.c:20:10: negation of -9223372036854775808 cannot be represented in type 'di_int' (aka 'long long'); cast to an unsigned type to negate this value to itself This can be avoided by doing negation in a matching unsigned variant of the type. The same kind of pattern is found in negti2.c This was found in an out of tree target. Reviewed By: MaskRay Differential Revision: https://reviews.llvm.org/D158818
This commit is contained in:
@@ -17,5 +17,5 @@
|
||||
COMPILER_RT_ABI di_int __negdi2(di_int a) {
|
||||
// Note: this routine is here for API compatibility; any sane compiler
|
||||
// should expand it inline.
|
||||
return -a;
|
||||
return -(du_int)a;
|
||||
}
|
||||
|
||||
@@ -19,7 +19,7 @@
|
||||
COMPILER_RT_ABI ti_int __negti2(ti_int a) {
|
||||
// Note: this routine is here for API compatibility; any sane compiler
|
||||
// should expand it inline.
|
||||
return -a;
|
||||
return -(tu_int)a;
|
||||
}
|
||||
|
||||
#endif // CRT_HAS_128BIT
|
||||
|
||||
Reference in New Issue
Block a user