fix various warnings

Change-Id: Ib01f381cb1a1c2f7259269603a47c39e39808494

src/jamidht/archive_account_manager.cpp

@@ -304,8 +304,6 @@ toString(AuthDecodingState state)
         return "AUTH"sv;
     case AuthDecodingState::DATA:
         return "DATA"sv;
-    case AuthDecodingState::ERR:
-        return "ERR"sv;
     case AuthDecodingState::AUTH_ERROR:
         return "AUTH_ERROR"sv;
     case AuthDecodingState::DONE:
@@ -314,6 +312,9 @@ toString(AuthDecodingState state)
         return "TIMEOUT"sv;
     case AuthDecodingState::CANCELED:
         return "CANCELED"sv;
+    case AuthDecodingState::ERR:
+    default:
+        return "ERR"sv;
     }
 }
 

src/jamidht/channel_handler.h

@@ -53,10 +53,9 @@ public:
                          bool forceNewConnection = false)
         = 0;
 
-    virtual void connect(const dht::InfoHash& infoHash,
-                         const std::string& name,
-                         ConnectCallbackLegacy&& cb)
-    {}
+    virtual void connect(const dht::InfoHash& /*infoHash*/,
+                         const std::string& /*name*/,
+                         ConnectCallbackLegacy&& /*cb*/) {}
 
     /**
      * Determine if we accept or not the request. Called when ConnectionManager receives a request

test/unitTest/linkdevice/linkdevice.cpp

@@ -112,7 +112,7 @@ LinkDeviceTest::tearDown()
         // try and cleanup the devices if the test fails or succeeds... this should usually fail due
         // to newDeviceId already being destroyed and same with oldDeviceId
         wait_for_removal_of({oldDeviceId, newDeviceId});
-    } catch (std::exception e) {
+    } catch (const std::exception& e) {
         JAMI_WARNING("[ut_linkdevice] Error during account cleanup... this should be ok.");
     }
 }