Media/compute-runtime
1
0
Fork 0
mirror of https://github.com/intel/compute-runtime.git synced 2025-09-15 13:01:45 +08:00
Code Issues Packages Projects Releases Wiki Activity

Update guidelines with rules regarding initialization of HW commands

Browse Source 
Change-Id: I96a35cb082482ca09111f391b9df6f0e3927920f
This commit is contained in:
Zdanowicz, Zbigniew
2019-01-29 13:23:58 +01:00
committed by sys_ocldev
parent 3e75c837f9
commit 4916a16cc5
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
documentation/GUIDELINES.md
View File

@ -37,9 +37,12 @@ TEST(CommandQueueTests, givenCommandQueueWhenEnqueueWithBlockingFlagIsSetThenDri
```
# Testing mindset
* Test behaviors instead of implementations, do not focus on adding a test per every function in the
* Test behaviors instead of implementations, do not focus on adding a test per every function in the
class (avoid tests for setters and getters), focus on the functionality you are adding and how it changes
the driver behavior, do not bind tests to implementation.
* Make sure that test is fast, our test suite needs to complete in seconds for efficient development pace, as
* Make sure that test is fast, our test suite needs to complete in seconds for efficient development pace, as
a general rule test shouldn't be longer then 1ms in Debug driver.
# Coding guidelines
* HW commands and structures used in NEO must be initialized with constants defines for each Gfx Family: i.e. PIPE_CONTROL cmd = GfxFamily::cmdInitPipeControl
* Any new HW command or structure must have its own static constant initializer added to any Gfx Family that is going to use it.