intel/llvm
1
0
Fork 0
mirror of https://github.com/intel/llvm.git synced 2026-01-12 18:27:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

[lldb] Show signal number description (#164176)

Browse Source 
show information about the signal when the user presses `process handle
<unix-signal>` i.e

```sh
(lldb) process handle SIGWINCH 
NAME         PASS   STOP   NOTIFY  DESCRIPTION
===========  =====  =====  ======  ===================
SIGWINCH     true   false  false   window size changes
```

Wanted to use the existing `GetSignalDescription` but it is expected
behaviour to return the signal name if no signal code is passed. It is
used in stop info.


65c895dfe0/lldb/source/Target/StopInfo.cpp (L1192-L1195)
This commit is contained in:
Ebuka Ezike
2025-11-24 11:59:05 +00:00
committed by GitHub
parent d162c91c01
commit 1dc6ad0081
4 changed files with 31 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
lldb/include/lldb/Target/UnixSignals.h
View File

@@ -31,6 +31,8 @@ public:
llvm::StringRef GetSignalAsStringRef(int32_t signo) const;
llvm::StringRef GetSignalNumberDescription(int32_t signo) const;
std::string
GetSignalDescription(int32_t signo,
std::optional<int32_t> code = std::nullopt,

13
lldb/source/Commands/CommandObjectProcess.cpp
View File

@@ -1603,8 +1603,8 @@ public:
Options *GetOptions() override { return &m_options; }
void PrintSignalHeader(Stream &str) {
str.Printf("NAME PASS STOP NOTIFY\n");
str.Printf("=========== ===== ===== ======\n");
str.Printf("NAME PASS STOP NOTIFY DESCRIPTION\n");
str.Printf("=========== ===== ===== ====== ===================\n");
}
void PrintSignal(Stream &str, int32_t signo, llvm::StringRef sig_name,
@@ -1615,9 +1615,16 @@ public:
str.Format("{0, -11} ", sig_name);
if (signals_sp->GetSignalInfo(signo, suppress, stop, notify)) {
bool pass = !suppress;
const bool pass = !suppress;
str.Printf("%s %s %s", (pass ? "true " : "false"),
(stop ? "true " : "false"), (notify ? "true " : "false"));
const llvm::StringRef sig_description =
signals_sp->GetSignalNumberDescription(signo);
if (!sig_description.empty()) {
str.PutCString(" ");
str.PutCString(sig_description);
}
}
str.Printf("\n");
}

7
lldb/source/Target/UnixSignals.cpp
View File

@@ -137,6 +137,13 @@ llvm::StringRef UnixSignals::GetSignalAsStringRef(int32_t signo) const {
return pos->second.m_name;
}
llvm::StringRef UnixSignals::GetSignalNumberDescription(int32_t signo) const {
const auto pos = m_signals.find(signo);
if (pos == m_signals.end())
return {};
return pos->second.m_description;
}
std::string UnixSignals::GetSignalDescription(
int32_t signo, std::optional<int32_t> code,
std::optional<lldb::addr_t> addr, std::optional<lldb::addr_t> lower,

12
lldb/unittests/Signals/UnixSignalsTest.cpp
View File

@@ -148,6 +148,18 @@ TEST(UnixSignalsTest, GetAsString) {
signals.GetSignalDescription(16, 3, 0x1233, 0x1234, 0x5678));
}
TEST(UnixSignalsTest, GetNumberDescription) {
TestSignals signals;
ASSERT_EQ("DESC2", signals.GetSignalNumberDescription(2));
ASSERT_EQ("DESC4", signals.GetSignalNumberDescription(4));
ASSERT_EQ("DESC8", signals.GetSignalNumberDescription(8));
ASSERT_EQ("DESC16", signals.GetSignalNumberDescription(16));
// Unknown signal number.
ASSERT_EQ("", signals.GetSignalNumberDescription(100));
}
TEST(UnixSignalsTest, VersionChange) {
TestSignals signals;